Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: pkg/compiler/lib/src/closure.dart

Issue 2924663002: Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst." (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/closure.dart
diff --git a/pkg/compiler/lib/src/closure.dart b/pkg/compiler/lib/src/closure.dart
index f4d53bc09bf4e68efa4f2138a43c34736ccb53ad..e19c69c27acebcdbd395159f8c37bd0dcb5e8c09 100644
--- a/pkg/compiler/lib/src/closure.dart
+++ b/pkg/compiler/lib/src/closure.dart
@@ -42,23 +42,26 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
DiagnosticReporter get reporter => compiler.reporter;
ClosureClassMap getMemberMap(MemberElement member) {
- return getClosureToClassMapping(member);
+ return getClosureToClassMapping(member.resolvedAst);
}
ClosureClassMap getLocalFunctionMap(LocalFunctionElement localFunction) {
- return getClosureToClassMapping(localFunction);
+ return getClosureToClassMapping(localFunction.resolvedAst);
}
/// Returns the [ClosureClassMap] computed for [resolvedAst].
- ClosureClassMap getClosureToClassMapping(Element element) {
+ ClosureClassMap getClosureToClassMapping(ResolvedAst resolvedAst) {
return measure(() {
+ Element element = resolvedAst.element;
if (element.isGenerativeConstructorBody) {
ConstructorBodyElement constructorBody = element;
element = constructorBody.constructor;
}
ClosureClassMap closureClassMap = _closureMappingCache[element];
- assert(closureClassMap != null,
- failedAt(element, "No ClosureClassMap computed for ${element}."));
+ assert(
+ closureClassMap != null,
+ failedAt(resolvedAst.element,
+ "No ClosureClassMap computed for ${element}."));
return closureClassMap;
});
}
@@ -75,22 +78,23 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
// Skip top-level/static fields without an initializer.
return;
}
- computeClosureToClassMapping(element, closedWorldRefiner);
+ computeClosureToClassMapping(resolvedAst, closedWorldRefiner);
});
}
ClosureClassMap computeClosureToClassMapping(
- Element element, ClosedWorldRefiner closedWorldRefiner) {
+ ResolvedAst resolvedAst, ClosedWorldRefiner closedWorldRefiner) {
return measure(() {
+ Element element = resolvedAst.element;
ClosureClassMap cached = _closureMappingCache[element];
if (cached != null) return cached;
- if (element.resolvedAst.kind != ResolvedAstKind.PARSED) {
+ if (resolvedAst.kind != ResolvedAstKind.PARSED) {
return _closureMappingCache[element] =
new ClosureClassMap(null, null, null, new ThisLocal(element));
}
return reporter.withCurrentElement(element.implementation, () {
- Node node = element.resolvedAst.node;
- TreeElements elements = element.resolvedAst.elements;
+ Node node = resolvedAst.node;
+ TreeElements elements = resolvedAst.elements;
ClosureTranslator translator = new ClosureTranslator(
compiler, closedWorldRefiner, elements, _closureMappingCache);
@@ -107,7 +111,7 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
} else {
assert(element.isField,
failedAt(element, "Expected $element to be a field."));
- Node initializer = element.resolvedAst.body;
+ Node initializer = resolvedAst.body;
if (initializer != null) {
// The lazy initializer of a static.
translator.translateLazyInitializer(element, node, initializer);
@@ -1135,7 +1139,6 @@ class ClosureTranslator extends Visitor {
compiler.backend.rtiNeed.methodNeedsRti(element);
}
}
- closureMappingCache[element] = closureData;
closureMappingCache[element.declaration] = closureData;
if (closureData.callElement != null) {
closureMappingCache[closureData.callElement] = closureData;
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698