Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2924643002: Explicitly setting names for stories in the power benchmarks (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
perezju, erikchen, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly setting names for stories in the power benchmarks BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924643002 Cr-Commit-Position: refs/heads/master@{#477957} Committed: https://chromium.googlesource.com/chromium/src/+/678f9a59f4f2794ac47ec48a781e65cffb87ef09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M tools/perf/page_sets/android_acceptance.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/idle_platform.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/trivial_sites.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/typical_10_mobile.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 18:49:07 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-05 18:50:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924643002/1
3 years, 6 months ago (2017-06-05 18:52:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310614)
3 years, 6 months ago (2017-06-05 20:53:40 UTC) #7
perezju
Is this setting the name to be just the url? Could we give better names ...
3 years, 6 months ago (2017-06-05 22:03:05 UTC) #8
ashleymarie1
On 2017/06/05 22:03:05, perezju wrote: > Is this setting the name to be just the ...
3 years, 6 months ago (2017-06-06 13:25:00 UTC) #9
ashleymarie1
On 2017/06/06 13:25:00, ashleymarie1 wrote: > On 2017/06/05 22:03:05, perezju wrote: > > Is this ...
3 years, 6 months ago (2017-06-06 13:27:34 UTC) #10
perezju
On 2017/06/06 at 13:27:34, ashleymarie wrote: > On 2017/06/06 13:25:00, ashleymarie1 wrote: > > On ...
3 years, 6 months ago (2017-06-07 14:30:00 UTC) #11
ashleymarie1
On 2017/06/07 14:30:00, perezju wrote: > On 2017/06/06 at 13:27:34, ashleymarie wrote: > > On ...
3 years, 6 months ago (2017-06-07 18:00:33 UTC) #12
perezju
lgtm
3 years, 6 months ago (2017-06-08 11:07:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924643002/1
3 years, 6 months ago (2017-06-08 12:29:56 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 14:19:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/678f9a59f4f2794ac47ec48a781e...

Powered by Google App Engine
This is Rietveld 408576698