Make RTCPeerConnectionHandlerTest use the webrtc signaling thread.

Make RTCPeerConnectionHandlerTest use the webrtc signaling thread.

The MockPeerConnectionDependecyFactory creates a new thread to act as
the webrtc signaling thread, but the RTCPeerConnectionHandlerTest
overrode its signaling_thread() helper method to yield the current
thread. This meant that different components used different threads as
their webrtc signaling thread in RTCPeerConnectionHandlerTest.

This causes problems if you introduce code that relies on the main and
and the webrtc signaling thread being different threads or if you DCHECK
which thread you belong to depending on which component you ask for the
webrtc signaling thread.

Code updated to use the same thread as the webrtc signaling thread in
all cases. base::RunLoop().RunUntilIdle() has been replaced by a helper
method RunMessageLoopsUntilIdle() which makes sure both webrtc and main
thread message loops has a chance to execute.

BUG=705901
Review-Url: https://codereview.chromium.org/2924563002
Cr-Commit-Position: refs/heads/master@{#476987}
Committed: https://chromium.googlesource.com/chromium/src/+/7e5d04b9bd8981b6cabd916203aa32423f41d493

[hbos_chromium, 2017-06-05 13:30:35]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 13:31:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2017-06-05 13:31:10]

hbos@chromium.org changed reviewers:
+ guidou@chromium.org

[hbos_chromium, 2017-06-05 13:31:10]

PTAL guidou

[Guido Urdaneta, 2017-06-05 13:45:18]

lgtm

[hbos_chromium, 2017-06-05 13:47:04]

The CQ bit was unchecked by hbos@chromium.org

[hbos_chromium, 2017-06-05 13:47:20]

The CQ bit was checked by hbos@chromium.org

[commit-bot: I haz the power, 2017-06-05 13:47:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 15:24:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496670440072470, "parent_rev":
"f035c8c0053e7bcec27f968bf7fbbfc062369e0f", "commit_rev":
"7e5d04b9bd8981b6cabd916203aa32423f41d493"}

[commit-bot: I haz the power, 2017-06-05 15:25:10]

Description was changed from

==========
Make RTCPeerConnectionHandlerTest use the webrtc signaling thread.

The MockPeerConnectionDependecyFactory creates a new thread to act as
the webrtc signaling thread, but the RTCPeerConnectionHandlerTest
overrode its signaling_thread() helper method to yield the current
thread. This meant that different components used different threads as
their webrtc signaling thread in RTCPeerConnectionHandlerTest.

This causes problems if you introduce code that relies on the main and
and the webrtc signaling thread being different threads or if you DCHECK
which thread you belong to depending on which component you ask for the
webrtc signaling thread.

Code updated to use the same thread as the webrtc signaling thread in
all cases. base::RunLoop().RunUntilIdle() has been replaced by a helper
method RunMessageLoopsUntilIdle() which makes sure both webrtc and main
thread message loops has a chance to execute.

BUG=705901
==========

to

==========
Make RTCPeerConnectionHandlerTest use the webrtc signaling thread.

The MockPeerConnectionDependecyFactory creates a new thread to act as
the webrtc signaling thread, but the RTCPeerConnectionHandlerTest
overrode its signaling_thread() helper method to yield the current
thread. This meant that different components used different threads as
their webrtc signaling thread in RTCPeerConnectionHandlerTest.

This causes problems if you introduce code that relies on the main and
and the webrtc signaling thread being different threads or if you DCHECK
which thread you belong to depending on which component you ask for the
webrtc signaling thread.

Code updated to use the same thread as the webrtc signaling thread in
all cases. base::RunLoop().RunUntilIdle() has been replaced by a helper
method RunMessageLoopsUntilIdle() which makes sure both webrtc and main
thread message loops has a chance to execute.

BUG=705901

Review-Url: https://codereview.chromium.org/2924563002
Cr-Commit-Position: refs/heads/master@{#476987}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e5d04b9bd8981b6cabd916203aa...
==========

[commit-bot: I haz the power, 2017-06-05 15:25:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e5d04b9bd8981b6cabd916203aa...