Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292443003: Add crendential smoke test for page sets. (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src
Visibility:
Public.

Description

Add crendential smoke test for page sets. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274144

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -28 lines) Patch
M tools/telemetry/telemetry/core/browser_credentials.py View 1 2 chunks +10 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest/page_set_smoke_test.py View 1 2 chunks +46 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nednguyen
6 years, 7 months ago (2014-05-15 22:00:39 UTC) #1
dtu
lgtm after comments and rebase https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py File tools/telemetry/telemetry/test_util/page_set_smoke_test.py (right): https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py#newcode46 tools/telemetry/telemetry/test_util/page_set_smoke_test.py:46: fail_message = ('page %s ...
6 years, 7 months ago (2014-05-16 00:27:59 UTC) #2
tonyg
lgtm https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py File tools/telemetry/telemetry/test_util/page_set_smoke_test.py (right): https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py#newcode40 tools/telemetry/telemetry/test_util/page_set_smoke_test.py:40: def CheckCredential(self, page_set): super minor nit: s/CheckCredential/CheckCredentials/
6 years, 7 months ago (2014-05-16 09:24:02 UTC) #3
nednguyen
https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py File tools/telemetry/telemetry/test_util/page_set_smoke_test.py (right): https://codereview.chromium.org/292443003/diff/1/tools/telemetry/telemetry/test_util/page_set_smoke_test.py#newcode40 tools/telemetry/telemetry/test_util/page_set_smoke_test.py:40: def CheckCredential(self, page_set): On 2014/05/16 09:24:02, tonyg wrote: > ...
6 years, 6 months ago (2014-06-01 17:52:19 UTC) #4
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-01 17:55:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/292443003/20001
6 years, 6 months ago (2014-06-01 17:55:20 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 20:11:04 UTC) #7
Message was sent while issue was closed. 
Change committed as 274144

Powered by Google App Engine
This is Rietveld 408576698