Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: tools/telemetry/telemetry/core/browser_credentials.py

Issue 292443003: Add crendential smoke test for page sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Address comments & rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/unittest/page_set_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser_credentials.py
diff --git a/tools/telemetry/telemetry/core/browser_credentials.py b/tools/telemetry/telemetry/core/browser_credentials.py
index 80fb181c54beeed906411ac8e180731efe78673e..d5f9d5ad90056854ae04d788ef5722a7d63fd504 100644
--- a/tools/telemetry/telemetry/core/browser_credentials.py
+++ b/tools/telemetry/telemetry/core/browser_credentials.py
@@ -12,6 +12,10 @@ from telemetry.core.backends import google_credentials_backend
from telemetry.unittest import options_for_unittests
+class CredentialsError(Exception):
+ """Error that can be thrown when logging in."""
+
+
class BrowserCredentials(object):
def __init__(self, backends = None):
self._credentials = {}
@@ -33,19 +37,22 @@ class BrowserCredentials(object):
def IsLoggedIn(self, credentials_type):
if credentials_type not in self._backends:
- raise Exception('Unrecognized credentials type: %s', credentials_type)
+ raise CredentialsError(
+ 'Unrecognized credentials type: %s', credentials_type)
if credentials_type not in self._credentials:
return False
return self._backends[credentials_type].IsLoggedIn()
def CanLogin(self, credentials_type):
if credentials_type not in self._backends:
- raise Exception('Unrecognized credentials type: %s', credentials_type)
+ raise CredentialsError(
+ 'Unrecognized credentials type: %s', credentials_type)
return credentials_type in self._credentials
def LoginNeeded(self, tab, credentials_type):
if credentials_type not in self._backends:
- raise Exception('Unrecognized credentials type: %s', credentials_type)
+ raise CredentialsError(
+ 'Unrecognized credentials type: %s', credentials_type)
if credentials_type not in self._credentials:
return False
return self._backends[credentials_type].LoginNeeded(
« no previous file with comments | « no previous file | tools/telemetry/telemetry/unittest/page_set_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698