Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924413002: DevTools: migrate sources navigator to shadow (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate sources navigator to shadow BUG=726972 Review-Url: https://codereview.chromium.org/2924413002 Cr-Commit-Position: refs/heads/master@{#478745} Committed: https://chromium.googlesource.com/chromium/src/+/815e8d6e7946a3ccd72b9c6249e83514ce3958ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
luoe
Please take a look
3 years, 6 months ago (2017-06-09 20:32:56 UTC) #2
dgozman
lgtm
3 years, 6 months ago (2017-06-12 18:08:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924413002/1
3 years, 6 months ago (2017-06-12 18:10:37 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 20:41:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/815e8d6e7946a3ccd72b9c6249e8...

Powered by Google App Engine
This is Rietveld 408576698