[Mac] Mirror content settings bubble in RTL.

[Mac] Mirror content settings bubble in RTL.

This layout is spread over 10 nibs, so it would be nice to just redo it
in code. It's a little risky IMO, so not doing it this CL.

BUG=726399
Review-Url: https://codereview.chromium.org/2924353002
Cr-Commit-Position: refs/heads/master@{#478336}
Committed: https://chromium.googlesource.com/chromium/src/+/6495c08b5e99164f9dd91c651abcada2a381f72d

[lgrey, 2017-06-08 20:37:04]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:37:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 20:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:54:58]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-06-09 15:48:11]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org

[lgrey, 2017-06-09 15:48:12]

PTAL :)

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h
(right):

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:66:
IBOutlet NSButton* infoButton_;
This was removed at some point (no specific comment why in the CL), but the
relevant nib still has the outlet. Needed to adjust margins for this button for
RTL.

[Avi (use Gerrit), 2017-06-09 17:41:05]

lgtm with comment nits.

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h
(right):

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:66:
IBOutlet NSButton* infoButton_;
On 2017/06/09 15:48:12, lgrey wrote:
> This was removed at some point (no specific comment why in the CL), but the
> relevant nib still has the outlet. Needed to adjust margins for this button
for
> RTL.

Acknowledged.

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
(right):

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:938: //
RTL-ize NIBS:
blank line above this comment to separate it from the previous code

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:947:
cocoa_l10n_util::FlipAllSubviewsIfNecessary([manageButton_ superview]);
for both of these line comments (941, 944), since they group with the lines
below them, space before them to make that clear.

[lgrey, 2017-06-09 17:59:13]

Thanks!

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
(right):

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:938: //
RTL-ize NIBS:
On 2017/06/09 17:41:05, Avi (OOO Mon 12-Fri 16) wrote:
> blank line above this comment to separate it from the previous code

Done.

https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:947:
cocoa_l10n_util::FlipAllSubviewsIfNecessary([manageButton_ superview]);
On 2017/06/09 17:41:05, Avi (OOO Mon 12-Fri 16) wrote:
> for both of these line comments (941, 944), since they group with the lines
> below them, space before them to make that clear.

Done.

[lgrey, 2017-06-09 17:59:17]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-06-09 17:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2924353002/#ps20001
(title: "Whitespace")

[commit-bot: I haz the power, 2017-06-09 17:59:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 18:18:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497031157919300,
"parent_rev": "5a866840ec589cd768ced41418bc2d89554e05ff", "commit_rev":
"6495c08b5e99164f9dd91c651abcada2a381f72d"}

[commit-bot: I haz the power, 2017-06-09 18:18:35]

Description was changed from

==========
[Mac] Mirror content settings bubble in RTL.

This layout is spread over 10 nibs, so it would be nice to just redo it
in code. It's a little risky IMO, so not doing it this CL.

BUG=726399
==========

to

==========
[Mac] Mirror content settings bubble in RTL.

This layout is spread over 10 nibs, so it would be nice to just redo it
in code. It's a little risky IMO, so not doing it this CL.

BUG=726399

Review-Url: https://codereview.chromium.org/2924353002
Cr-Commit-Position: refs/heads/master@{#478336}
Committed:
https://chromium.googlesource.com/chromium/src/+/6495c08b5e99164f9dd91c651abc...
==========

[commit-bot: I haz the power, 2017-06-09 18:18:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6495c08b5e99164f9dd91c651abc...