Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2924353002: [Mac] Mirror content settings bubble in RTL. (Closed)

Created:
3 years, 6 months ago by lgrey
Modified:
3 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Mirror content settings bubble in RTL. This layout is spread over 10 nibs, so it would be nice to just redo it in code. It's a little risky IMO, so not doing it this CL. BUG=726399 Review-Url: https://codereview.chromium.org/2924353002 Cr-Commit-Position: refs/heads/master@{#478336} Committed: https://chromium.googlesource.com/chromium/src/+/6495c08b5e99164f9dd91c651abcada2a381f72d

Patch Set 1 #

Total comments: 6

Patch Set 2 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lgrey
PTAL :) https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h (right): https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h#newcode66 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:66: IBOutlet NSButton* infoButton_; This was removed at ...
3 years, 6 months ago (2017-06-09 15:48:12 UTC) #6
Avi (use Gerrit)
lgtm with comment nits. https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h (right): https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h#newcode66 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:66: IBOutlet NSButton* infoButton_; On 2017/06/09 ...
3 years, 6 months ago (2017-06-09 17:41:05 UTC) #7
lgrey
Thanks! https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/2924353002/diff/1/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode938 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:938: // RTL-ize NIBS: On 2017/06/09 17:41:05, Avi (OOO ...
3 years, 6 months ago (2017-06-09 17:59:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924353002/20001
3 years, 6 months ago (2017-06-09 17:59:44 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 18:18:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6495c08b5e99164f9dd91c651abc...

Powered by Google App Engine
This is Rietveld 408576698