Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 292433015: Refactor MetricsLogChromeOS to ChromeOSMetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_log.cc
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index 254bd4eaf5d63ca4f2f60b815ea6996ddffa0f38..f6d2c590baceb03687d523c1833c42db76eba2fc 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -55,10 +55,6 @@
extern "C" IMAGE_DOS_HEADER __ImageBase;
#endif
-#if defined(OS_CHROMEOS)
-#include "chrome/browser/metrics/metrics_log_chromeos.h"
-#endif // OS_CHROMEOS
-
using content::GpuDataManager;
using metrics::MetricsLogBase;
using metrics::ProfilerEventProto;
@@ -293,10 +289,6 @@ MetricsLog::MetricsLog(const std::string& client_id,
extension_metrics_(uma_proto()->client_id()) {
uma_proto()->mutable_system_profile()->set_channel(
AsProtobufChannel(chrome::VersionInfo::GetChannel()));
-
-#if defined(OS_CHROMEOS)
- metrics_log_chromeos_.reset(new MetricsLogChromeOS(uma_proto()));
-#endif // OS_CHROMEOS
}
MetricsLog::~MetricsLog() {}
@@ -555,10 +547,6 @@ void MetricsLog::WriteRealtimeStabilityAttributes(
pref->SetInteger(prefs::kStabilityChildProcessCrashCount, 0);
}
-#if defined(OS_CHROMEOS)
- metrics_log_chromeos_->WriteRealtimeStabilityAttributes(pref);
-#endif // OS_CHROMEOS
-
const uint64 incremental_uptime_sec = incremental_uptime.InSeconds();
if (incremental_uptime_sec)
stability->set_incremental_uptime_sec(incremental_uptime_sec);
@@ -684,10 +672,6 @@ void MetricsLog::RecordEnvironment(
WriteFieldTrials(field_trial_ids, system_profile);
WriteFieldTrials(synthetic_trials, system_profile);
-#if defined(OS_CHROMEOS)
- metrics_log_chromeos_->LogChromeOSMetrics();
-#endif // OS_CHROMEOS
-
for (size_t i = 0; i < metrics_providers.size(); ++i)
metrics_providers[i]->ProvideSystemProfileMetrics(system_profile);

Powered by Google App Engine
This is Rietveld 408576698