chrome/browser/metrics/metrics_log.h - Issue 292433015: Refactor MetricsLogChromeOS to ChromeOSMetricsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.h

Issue 292433015: Refactor MetricsLogChromeOS to ChromeOSMetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chromeos_metrics_provider.cc ('K') | « chrome/browser/metrics/chromeos_metrics_provider_unittest.cc ('k') | chrome/browser/metrics/metrics_log.cc » ('j') | chrome/browser/metrics/metrics_log_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_log.h

diff --git a/chrome/browser/metrics/metrics_log.h b/chrome/browser/metrics/metrics_log.h

index 8cd2eea969695f1d9b6c6481effe9caf51699637..6992ce46b87d492c7e526b9b0d67228c44f649a5 100644

--- a/chrome/browser/metrics/metrics_log.h

+++ b/chrome/browser/metrics/metrics_log.h

@@ -24,10 +24,6 @@ class MetricsNetworkObserver;

class PrefService;

class PrefRegistrySimple;

-#if defined(OS_CHROMEOS)

-class MetricsLogChromeOS;

-#endif

namespace base {

class DictionaryValue;

}

@@ -131,11 +127,6 @@ class MetricsLog : public metrics::MetricsLogBase {

virtual void GetFieldTrialIds(

std::vector<variations::ActiveGroupId>* field_trial_ids) const;

- // Exposed to allow dependency injection for tests.

-#if defined(OS_CHROMEOS)

- scoped_ptr<MetricsLogChromeOS> metrics_log_chromeos_;

-#endif

private:

FRIEND_TEST_ALL_PREFIXES(MetricsLogTest, ChromeOSStabilityData);