Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 292433004: Revert 270750 "Android: cleans up jni_generator_ptr_type." (Closed)

Created:
6 years, 7 months ago by jiayl
Modified:
6 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 270750 "Android: cleans up jni_generator_ptr_type." Suspected to cause Android Tests bot failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13592 > Android: cleans up jni_generator_ptr_type. > > The underlying rule is now "long" by default. > Mechanical change: > git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d > > BUG=317523 > TBR=darin@chromium.org > > Review URL: https://codereview.chromium.org/288963002 TBR=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M trunk/src/android_webview/android_webview_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/android_webview/native/webview_native.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/base/android/jni_generator/jni_generator.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/base/base.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/components/cronet.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/components/navigation_interception.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/components/web_contents_delegate_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/media/media.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/mojo/mojo.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/net/net.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/printing/printing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/remoting/remoting_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/sync/sync_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/testing/android/native_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/gfx/gfx.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/gl/gl.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jiayl
6 years, 7 months ago (2014-05-15 23:23:45 UTC) #1
jiayl
6 years, 7 months ago (2014-05-15 23:23:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r270849.

Powered by Google App Engine
This is Rietveld 408576698