Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 288963002: Android: cleans up jni_generator_ptr_type. (Closed)

Created:
6 years, 7 months ago by bulach
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, haitaol+watch_chromium.org, viettrungluu+watch_chromium.org, jam, klundberg+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach+watch_chromium.org, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org, android-webview-reviews_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Android: cleans up jni_generator_ptr_type. The underlying rule is now "long" by default. Mechanical change: git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d BUG=317523 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/webview_native.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/jni_generator/jni_generator.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/navigation_interception.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_contents_delegate_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_jni.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/mojo.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sync_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ross, john, ptal, just for sanity :) since it's a purely mechanical safe cleanup, I'll ...
6 years, 7 months ago (2014-05-15 13:24:31 UTC) #1
johnme
lgtm
6 years, 7 months ago (2014-05-15 13:27:10 UTC) #2
rmcilroy
On 2014/05/15 13:27:10, johnme wrote: > lgtm lgtm, thanks.
6 years, 7 months ago (2014-05-15 13:52:56 UTC) #3
bulach
CQing, TBR=darin (purely mechanical changes across gyp)
6 years, 7 months ago (2014-05-15 14:52:57 UTC) #4
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 7 months ago (2014-05-15 14:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/288963002/1
6 years, 7 months ago (2014-05-15 14:54:35 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 18:35:59 UTC) #7
Message was sent while issue was closed.
Change committed as 270750

Powered by Google App Engine
This is Rietveld 408576698