Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2924303002: Omnibox UI: Fix Cocoa suggestion lines for short lines (again). (Closed)

Created:
3 years, 6 months ago by tommycli
Modified:
3 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox UI: Fix Cocoa suggestion lines for short lines (again). BUG=731025 Review-Url: https://codereview.chromium.org/2924303002 Cr-Commit-Position: refs/heads/master@{#478432} Committed: https://chromium.googlesource.com/chromium/src/+/edcd7da1e6157b263551180f0e26c1a826452d53

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : Fix answers in suggest case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tommycli
groby: PTAL, take 2. Used NSWidth instead of NSHeight by accident.
3 years, 6 months ago (2017-06-08 17:38:24 UTC) #2
tommycli
On 2017/06/08 17:38:24, tommycli wrote: > groby: PTAL, take 2. Used NSWidth instead of NSHeight ...
3 years, 6 months ago (2017-06-09 21:32:39 UTC) #7
groby-ooo-7-16
lgtm
3 years, 6 months ago (2017-06-09 21:41:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924303002/40001
3 years, 6 months ago (2017-06-09 21:57:41 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 22:02:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/edcd7da1e6157b263551180f0e26...

Powered by Google App Engine
This is Rietveld 408576698