Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2924293002: PlzNavigate: Fix wrong SourceLocation. (Closed)

Created:
3 years, 6 months ago by jam
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Fix wrong SourceLocation. Before this CL, when an iframe is asked to navigate, the SourceLocation used was the wrong one. It was always the one of the current document, even when the navigation was initiated by another frame. TEST=http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html The test still does not pass however. It is due to https://crbug.com/718942 which is not related to this issue. BUG=690946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2901223003 Cr-Original-Commit-Position: refs/heads/master@{#476613} Review-Url: https://codereview.chromium.org/2924293002 . Cr-Commit-Position: refs/branch-heads/3112@{#257} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/536326a013d7b979106706b80e964dc803c160c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 2 chunks +25 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 4 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 6 months ago (2017-06-08 17:20:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
536326a013d7b979106706b80e964dc803c160c5.

Powered by Google App Engine
This is Rietveld 408576698