Improve zombie process error message to be actionable.

Improve zombie process error message to be actionable.

Give more background information about what is happening and why this is bad, as
the previous message was not actionable at all.

R=tandrii@chromium.org
BUG=730969
Review-Url: https://codereview.chromium.org/2924283002
Committed: https://github.com/luci/luci-py/commit/70b369823ed763667b503adde008eb765d55846a

[tandrii(chromium), 2017-06-08 14:27:51]

lgmt % suggestion

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:117: bot, don't you? The Swarming bot doesn't.
don't you? => do you?

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:127: - You have %s seconds to comply after the signal was
sent to the process.
perhaps you imply here that this signal was sent...
...by the swarming bot itself?

If so, perhaps this is better:

 - Swarming bot may send a signal to your main process, after which you have %s
seconds to comply by terminating your complete process tree.

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:133: *** May the SIGKILL force be with you ***
:)

[tandrii(chromium), 2017-06-08 14:27:52]

lgmt % suggestion

[M-A Ruel, 2017-06-08 15:02:48]

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:117: bot, don't you? The Swarming bot doesn't.
On 2017/06/08 14:27:51, tandrii(chromium) wrote:
> don't you? => do you?

Done.

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:127: - You have %s seconds to comply after the signal was
sent to the process.
On 2017/06/08 14:27:50, tandrii(chromium) wrote:
> perhaps you imply here that this signal was sent...
> ...by the swarming bot itself?
> 
> If so, perhaps this is better:
> 
>  - Swarming bot may send a signal to your main process, after which you have
%s
> seconds to comply by terminating your complete process tree.

Reworded, please reread.

[tandrii(chromium), 2017-06-08 15:16:11]

lgtm

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2924283002/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:127: - You have %s seconds to comply after the signal was
sent to the process.
On 2017/06/08 15:02:48, M-A Ruel wrote:
> On 2017/06/08 14:27:50, tandrii(chromium) wrote:
> > perhaps you imply here that this signal was sent...
> > ...by the swarming bot itself?
> > 
> > If so, perhaps this is better:
> > 
> >  - Swarming bot may send a signal to your main process, after which you have
> %s
> > seconds to comply by terminating your complete process tree.
> 
> Reworded, please reread.

Really good. Thank you.

[M-A Ruel, 2017-06-08 15:17:21]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2017-06-08 15:17:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 15:20:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496935041409900,
"parent_rev": "1bd482d4014fd63fb2a263fd3e60b328f8be59ab", "commit_rev":
"70b369823ed763667b503adde008eb765d55846a"}

[commit-bot: I haz the power, 2017-06-08 15:20:07]

Description was changed from

==========
Improve zombie process error message to be actionable.

Give more background information about what is happening and why this is bad, as
the previous message was not actionable at all.

R=tandrii@chromium.org
BUG=730969
==========

to

==========
Improve zombie process error message to be actionable.

Give more background information about what is happening and why this is bad, as
the previous message was not actionable at all.

R=tandrii@chromium.org
BUG=730969

Review-Url: https://codereview.chromium.org/2924283002
Committed:
https://github.com/luci/luci-py/commit/70b369823ed763667b503adde008eb765d55846a
==========

[commit-bot: I haz the power, 2017-06-08 15:20:08]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/70b369823ed763667b503adde008eb765d55846a

[Taylor_Brandstetter, 2017-06-08 17:58:46]

deadbeef@chromium.org changed reviewers:
+ deadbeef@chromium.org

[Taylor_Brandstetter, 2017-06-08 17:58:46]

https://codereview.chromium.org/2924283002/diff/20001/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2924283002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:595: sys.stderr.write(OUTLIVING_ZOMBIE_MSG % ('run',
grace_period))
Should be "temp"?

[M-A Ruel, 2017-06-08 18:14:07]

https://codereview.chromium.org/2924283002/diff/20001/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2924283002/diff/20001/client/run_isolated.py#...
client/run_isolated.py:595: sys.stderr.write(OUTLIVING_ZOMBIE_MSG % ('run',
grace_period))
On 2017/06/08 17:58:46, Taylor_Brandstetter wrote:
> Should be "temp"?

Argh, I got caught copy-pasting. Fixing.