Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2924263003: [LayoutNG] Initial letter-spacing and word-spacing support (Closed)

Created:
3 years, 6 months ago by kojii
Modified:
3 years, 5 months ago
Reviewers:
ikilpatrick, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, glebl+reviews_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Initial letter-spacing and word-spacing support This patch adds initial support for letter-spacing and word-spacing. ShapeResultSpacing is templatized to share the code with TextRun. This patch does not support ShapingLineBreaker yet. When it reshapes, we need to apply spacing to reshaped parts. I'll work on it in following patches. Justification in LayoutNG is not supported yet either. It will be following work too. BUG=636993 Review-Url: https://codereview.chromium.org/2924263003 Cr-Commit-Position: refs/heads/master@{#478724} Committed: https://chromium.googlesource.com/chromium/src/+/964fc7fe50b27ffb527e3e237e46650c18599578

Patch Set 1 #

Patch Set 2 : win build fix #

Patch Set 3 : WIP #

Patch Set 4 : Cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -50 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 3 chunks +5 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 1 2 4 chunks +15 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.h View 1 2 3 1 chunk +24 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp View 1 2 3 4 chunks +77 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
kojii
PTAL.
3 years, 6 months ago (2017-06-12 17:08:31 UTC) #8
eae
Clever, LGTM!
3 years, 6 months ago (2017-06-12 17:13:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924263003/60001
3 years, 6 months ago (2017-06-12 17:13:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 6 months ago (2017-06-12 19:15:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924263003/60001
3 years, 6 months ago (2017-06-12 19:38:22 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/964fc7fe50b27ffb527e3e237e46650c18599578
3 years, 6 months ago (2017-06-12 19:46:35 UTC) #19
ikilpatrick
https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h File third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h (right): https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h#newcode60 third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h:60: if (!run.SpacingDisabled()) Can you add a comment here as ...
3 years, 5 months ago (2017-06-29 16:17:59 UTC) #21
ikilpatrick
3 years, 5 months ago (2017-06-29 16:18:00 UTC) #22
ikilpatrick
3 years, 5 months ago (2017-06-29 16:18:01 UTC) #23
kojii
3 years, 5 months ago (2017-06-29 18:55:48 UTC) #24
Message was sent while issue was closed.
On 2017/06/29 at 16:17:59, ikilpatrick wrote:
>
https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
(right):
> 
>
https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h:60:
if (!run.SpacingDisabled())
> Can you add a comment here as to why spacing might be disabled, and what this
does?

Will do. It's SVG folks added, the code that calls TextRun::DisableSpacing()
says:
 // We handle letter & word spacing ourselves.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/sv...

Powered by Google App Engine
This is Rietveld 408576698