[LayoutNG] Initial letter-spacing and word-spacing support

[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993
Review-Url: https://codereview.chromium.org/2924263003
Cr-Commit-Position: refs/heads/master@{#478724}
Committed: https://chromium.googlesource.com/chromium/src/+/964fc7fe50b27ffb527e3e237e46650c18599578

[kojii, 2017-06-08 13:30:06]

Description was changed from

==========
WIP: spacing

BUG=
==========

to

==========
WIP: spacing

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-09 14:15:24]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 14:15:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-09 14:27:48]

Description was changed from

==========
WIP: spacing

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[commit-bot: I haz the power, 2017-06-09 16:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 16:19:17]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-06-12 17:08:30]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-06-12 17:08:31]

PTAL.

[eae, 2017-06-12 17:13:28]

Clever, LGTM!

[eae, 2017-06-12 17:13:34]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-06-12 17:13:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:15:25]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-06-12 19:37:52]

Description was changed from

==========
[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993
==========

[kojii, 2017-06-12 19:37:54]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:38:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:46:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497296274090650,
"parent_rev": "a50035b77e0529cb0c916d19e18da91152c6dc69", "commit_rev":
"964fc7fe50b27ffb527e3e237e46650c18599578"}

[commit-bot: I haz the power, 2017-06-12 19:46:33]

Description was changed from

==========
[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993
==========

to

==========
[LayoutNG] Initial letter-spacing and word-spacing support

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993

Review-Url: https://codereview.chromium.org/2924263003
Cr-Commit-Position: refs/heads/master@{#478724}
Committed:
https://chromium.googlesource.com/chromium/src/+/964fc7fe50b27ffb527e3e237e46...
==========

[commit-bot: I haz the power, 2017-06-12 19:46:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/964fc7fe50b27ffb527e3e237e46...

[ikilpatrick, 2017-06-29 16:17:58]

ikilpatrick@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2017-06-29 16:17:59]

https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
(right):

https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h:60:
if (!run.SpacingDisabled())
Can you add a comment here as to why spacing might be disabled, and what this
does?

[kojii, 2017-06-29 18:55:48]

On 2017/06/29 at 16:17:59, ikilpatrick wrote:
>
https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
(right):
> 
>
https://codereview.chromium.org/2924263003/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h:60:
if (!run.SpacingDisabled())
> Can you add a comment here as to why spacing might be disabled, and what this
does?

Will do. It's SVG folks added, the code that calls TextRun::DisableSpacing()
says:
 // We handle letter & word spacing ourselves.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/sv...