[MD Bookmarks] Add bookmark count to context menu for multiple items.

[MD Bookmarks] Add bookmark count to context menu for multiple items.

This CL adds the bookmark count to the end of the 'Open in new tab'
option for the context menu when multiple bookmarks will be opened.

BUG=708815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2924253002
Cr-Commit-Position: refs/heads/master@{#481161}
Committed: https://chromium.googlesource.com/chromium/src/+/64e2012a9e0278ff735674d16db1c44caefc91ae

[calamity, 2017-06-08 07:40:11]

Description was changed from

==========
[MD Bookmarks] Add bookmark count to context menu for multiple items.

This CL adds the bookmark count to the end of the 'Open in new tab'
option for the context menu when multiple bookmarks will be opened.

BUG=708815
==========

to

==========
[MD Bookmarks] Add bookmark count to context menu for multiple items.

This CL adds the bookmark count to the end of the 'Open in new tab'
option for the context menu when multiple bookmarks will be opened.

BUG=708815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-06-08 07:50:25]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 07:50:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 08:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 08:02:23]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[calamity, 2017-06-13 04:36:14]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2017-06-13 06:01:41]

Do you mind running this past Alan before we go ahead with this? Just send an
email with a screenshot of this and remind him of the other alternatives.

This idea came up relatively off-hand in a sync meeting, so I'd like to make
sure he's still on board.

[tsergeant, 2017-06-16 00:25:58]

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.html (right):

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:21: width: 24px;
Consider this optional, but maybe it would be better to have

width: 3ch;

here? That means that the sublabel is exactly big enough for 3 numbers,
regardless of font size. It depends on how the sizing is meant to work, I guess.

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:24:
:not(:host([has-any-sublabel_])).sublabel {
This selector doesn't work.

I think you need something like

:host(:not([has-any-sublabel_])) .sublabel

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:29: display: flex;
I don't think this is necessary? .dropdown-item is already flex.

[calamity, 2017-06-20 03:30:39]

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.html (right):

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:21: width: 24px;
On 2017/06/16 00:25:58, tsergeant wrote:
> Consider this optional, but maybe it would be better to have
> 
> width: 3ch;
> 
> here? That means that the sublabel is exactly big enough for 3 numbers,
> regardless of font size. It depends on how the sizing is meant to work, I
guess.

Done.

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:24:
:not(:host([has-any-sublabel_])).sublabel {
On 2017/06/16 00:25:58, tsergeant wrote:
> This selector doesn't work.
> 
> I think you need something like
> 
> :host(:not([has-any-sublabel_])) .sublabel

Done.

https://codereview.chromium.org/2924253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.html:29: display: flex;
On 2017/06/16 00:25:58, tsergeant wrote:
> I don't think this is necessary? .dropdown-item is already flex.

Done.

[tsergeant, 2017-06-20 04:07:24]

lgtm

[calamity, 2017-06-21 08:42:46]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2017-06-21 08:42:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 09:57:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498034566679990,
"parent_rev": "6faeef0f0300547242c025a122479b7e036d3e46", "commit_rev":
"64e2012a9e0278ff735674d16db1c44caefc91ae"}

[commit-bot: I haz the power, 2017-06-21 09:57:29]

Description was changed from

==========
[MD Bookmarks] Add bookmark count to context menu for multiple items.

This CL adds the bookmark count to the end of the 'Open in new tab'
option for the context menu when multiple bookmarks will be opened.

BUG=708815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add bookmark count to context menu for multiple items.

This CL adds the bookmark count to the end of the 'Open in new tab'
option for the context menu when multiple bookmarks will be opened.

BUG=708815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2924253002
Cr-Commit-Position: refs/heads/master@{#481161}
Committed:
https://chromium.googlesource.com/chromium/src/+/64e2012a9e0278ff735674d16db1...
==========

[commit-bot: I haz the power, 2017-06-21 09:57:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/64e2012a9e0278ff735674d16db1...