Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2924193004: supersize: Show relocations in section totals (Closed)

Created:
3 years, 6 months ago by agrieve
Modified:
3 years, 6 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Show relocations in section totals This should make it obvious when binary size growth is due to relocations. BUG=726151 Review-Url: https://codereview.chromium.org/2924193004 Cr-Commit-Position: refs/heads/master@{#478055} Committed: https://chromium.googlesource.com/chromium/src/+/ffd9b04d92c4a7052471a6a20686dbd95b53093d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M tools/binary_size/libsupersize/describe.py View 2 chunks +25 lines, -7 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 chunk +8 lines, -6 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 chunk +1 line, -2 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/06/08 17:50:05, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🔩
3 years, 6 months ago (2017-06-08 17:50:16 UTC) #3
estevenson
lgtm
3 years, 6 months ago (2017-06-08 18:24:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924193004/1
3 years, 6 months ago (2017-06-08 19:20:34 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 19:35:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffd9b04d92c4a7052471a6a20686...

Powered by Google App Engine
This is Rietveld 408576698