Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2924173002:
Update the text of the button to download page later on error (Closed)
DescriptionUpdate the text of the button to download page later on error
BUG=730342
Review-Url: https://codereview.chromium.org/2924173002
Cr-Commit-Position: refs/heads/master@{#479163}
Committed: https://chromium.googlesource.com/chromium/src/+/762bb48da4b3ff06e5a6c108c0f1f9f3c6050619
Patch Set 1 #Patch Set 2 : Update text of another button #
Total comments: 2
Patch Set 3 : Fix #
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by jianli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jianli@chromium.org changed reviewers: + edwardjung@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jianli@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
jianli@chromium.org changed reviewers: + mmenke@chromium.org
mmenke, could you please approve the patch? Thanks.
On 2017/06/08 20:23:55, jianli wrote: > mmenke, could you please approve the patch? Thanks. LGTM, rubberstamp, deferring to Edward.
The CQ bit was checked by jianli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
edwardjung, could you please take another look at new patch since I just received a text update for another related button? Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2924173002/diff/20001/components/error_page_s... File components/error_page_strings.grdp (right): https://codereview.chromium.org/2924173002/diff/20001/components/error_page_s... components/error_page_strings.grdp:34: Waiting for connection... Could we use an ellipsis '…' character rather than three dots '...'
The CQ bit was checked by jianli@chromium.org to run a CQ dry run
https://codereview.chromium.org/2924173002/diff/20001/components/error_page_s... File components/error_page_strings.grdp (right): https://codereview.chromium.org/2924173002/diff/20001/components/error_page_s... components/error_page_strings.grdp:34: Waiting for connection... On 2017/06/12 16:53:17, edwardjung wrote: > Could we use an ellipsis '…' character rather than three dots '...' Done.
LGTM again
The CQ bit was checked by jianli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org Link to the patchset: https://codereview.chromium.org/2924173002/#ps40001 (title: "Fix")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497385238335160,
"parent_rev": "9fc9d951c4b4757038d8ae9dbeafd43bea88aab3", "commit_rev":
"762bb48da4b3ff06e5a6c108c0f1f9f3c6050619"}
Message was sent while issue was closed.
Description was changed from ========== Update the text of the button to download page later on error BUG=730342 ========== to ========== Update the text of the button to download page later on error BUG=730342 Review-Url: https://codereview.chromium.org/2924173002 Cr-Commit-Position: refs/heads/master@{#479163} Committed: https://chromium.googlesource.com/chromium/src/+/762bb48da4b3ff06e5a6c108c0f1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/762bb48da4b3ff06e5a6c108c0f1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
