[system_health] Fix the lack of memory dump triggers on some user stories

[system_health] Fix the lack of memory dump triggers on some user stories

Some system health stories have been overriding RunPageInteractions method directly
without implementing memory dump triggering.

This fixes those stories by changing them to override _DidLoadStory. It also add
tests to avoid mistakes like these in the future.

Review-Url: https://codereview.chromium.org/2924163005
Cr-Commit-Position: refs/heads/master@{#477949}
Committed: https://chromium.googlesource.com/chromium/src/+/61a28216c8afa4d39dedb3dda02c179cf22d5f63

[nednguyen, 2017-06-08 05:09:10]

nednguyen@google.com changed reviewers:
+ erikchen@chromium.org, perezju@chromium.org

[nednguyen, 2017-06-08 05:09:10]

I discover this bug when looking at the memory trace of multitab:misc:typical24
story.

*Sigh*

[nednguyen, 2017-06-08 05:09:15]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 05:09:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 07:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 07:28:31]

Dry run: This issue passed the CQ dry run.

[perezju, 2017-06-08 12:36:47]

lgtm

oh, great catch! yeah, this was a bad mistake :-/

[nednguyen, 2017-06-08 12:50:45]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-06-08 12:51:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 12:55:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496926245150150, "parent_rev":
"8ad19ec2f37cc95d1ac660e7c605f1fb029e5dfc", "commit_rev":
"61a28216c8afa4d39dedb3dda02c179cf22d5f63"}

[commit-bot: I haz the power, 2017-06-08 12:55:33]

Description was changed from

==========
[system_health] Fix the lack of memory dump triggers on some user stories

Some system health stories have been overriding RunPageInteractions method
directly
without implementing memory dump triggering.

This fixes those stories by changing them to override _DidLoadStory. It also add
tests to avoid mistakes like these in the future.
==========

to

==========
[system_health] Fix the lack of memory dump triggers on some user stories

Some system health stories have been overriding RunPageInteractions method
directly
without implementing memory dump triggering.

This fixes those stories by changing them to override _DidLoadStory. It also add
tests to avoid mistakes like these in the future.

Review-Url: https://codereview.chromium.org/2924163005
Cr-Commit-Position: refs/heads/master@{#477949}
Committed:
https://chromium.googlesource.com/chromium/src/+/61a28216c8afa4d39dedb3dda02c...
==========

[commit-bot: I haz the power, 2017-06-08 12:55:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61a28216c8afa4d39dedb3dda02c...