[vr] Fix incorrect negation in font fallback logic.

[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG=730868
Review-Url: https://codereview.chromium.org/2924043003
Cr-Commit-Position: refs/heads/master@{#477857}
Committed: https://chromium.googlesource.com/chromium/src/+/be8255189966eb57a2c70ca3d57568af4b144e14

[Ian Vollick, 2017-06-07 23:59:40]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 00:00:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 00:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 00:52:09]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2017-06-08 01:07:56]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 01:08:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2017-06-08 01:08:47]

Description was changed from

==========
[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG=730868
==========

to

==========
[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG=730868
==========

[Ian Vollick, 2017-06-08 01:08:47]

vollick@chromium.org changed reviewers:
+ cjgrant@chromium.org, mthiesse@chromium.org

[mthiesse, 2017-06-08 01:13:18]

https://codereview.chromium.org/2924043003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/textures/ui_texture.cc (left):

https://codereview.chromium.org/2924043003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/textures/ui_texture.cc:196: if (name.empty())
Did you forget the main fix? ;)

[Ian Vollick, 2017-06-08 01:15:10]

Patchset #3 (id:40001) has been deleted

[Ian Vollick, 2017-06-08 01:15:44]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 01:15:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2017-06-08 01:16:20]

On 2017/06/08 01:13:18, mthiesse wrote:
>
https://codereview.chromium.org/2924043003/diff/20001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/textures/ui_texture.cc (left):
> 
>
https://codereview.chromium.org/2924043003/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/textures/ui_texture.cc:196: if (name.empty())
> Did you forget the main fix? ;)

I sure did!

[mthiesse, 2017-06-08 01:21:48]

lgtm

[Ian Vollick, 2017-06-08 01:22:43]

The CQ bit was unchecked by vollick@chromium.org

[Ian Vollick, 2017-06-08 01:22:47]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2017-06-08 01:22:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cjgrant, 2017-06-08 01:41:15]

lgtm

https://codereview.chromium.org/2924043003/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/textures/ui_texture.cc (right):

https://codereview.chromium.org/2924043003/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/textures/ui_texture.cc:200:
DCHECK(!name.empty());
This DCHECK will lead a lonely life. :)

[commit-bot: I haz the power, 2017-06-08 01:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496884967075360,
"parent_rev": "66e276cfca435df9c8c5d42580a6a88406b311fe", "commit_rev":
"be8255189966eb57a2c70ca3d57568af4b144e14"}

[commit-bot: I haz the power, 2017-06-08 01:58:32]

Description was changed from

==========
[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG=730868
==========

to

==========
[vr] Fix incorrect negation in font fallback logic.

We were previously only adding empty fallback fonts.

BUG=730868

Review-Url: https://codereview.chromium.org/2924043003
Cr-Commit-Position: refs/heads/master@{#477857}
Committed:
https://chromium.googlesource.com/chromium/src/+/be8255189966eb57a2c70ca3d575...
==========

[commit-bot: I haz the power, 2017-06-08 01:58:33]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/be8255189966eb57a2c70ca3d575...