DescriptionTrackObserver DCHECK not on main thread, tests updated.
The test was using a ThreadChecker to check that OnChanged is invoked
on the webrtc signaling thread. The problem is it is attached to
whatever thread first calls OnChanged, which in several tests was the
main thread.
The DCHECK is changed to "not on main thread", which should imply its
invoked on the webrtc signaling thread. This is good enough, and
avoids refactoring and changing initialization order that would be
necessary to pass the webrtc signaling thread for the sake of a single
DCHECK.
The DCHECK showed that RTCPeerConnectionHandlerTest and
MediaStreamRemoteVideoSourceTest was using the TrackObserver on the
wrong thread - tests are updated.
BUG=705901
Review-Url: https://codereview.chromium.org/2924033002
Cr-Commit-Position: refs/heads/master@{#478569}
Committed: https://chromium.googlesource.com/chromium/src/+/9e96b2036f3956bdf7bfc180044b90b71496a454
Patch Set 1 #Patch Set 2 : MediaStreamRemoteVideoSourceTest using the signaling thread #
Messages
Total messages: 20 (16 generated)
|