Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts

Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts

Rename CreateDragImage to CreateDragImageForFrame to avoid name
conflicts and add TODO for movement of drag related functionality
out of LocalFrame class.
These functionalities are independent of core functionality of
LocalFrame so these can be moved out of LocalFrame.

BUG=727981
Review-Url: https://codereview.chromium.org/2924013002
Cr-Commit-Position: refs/heads/master@{#477919}
Committed: https://chromium.googlesource.com/chromium/src/+/857d0cf0147891b495e4df5260bb1e51be5e3980

[tanvir, 2017-06-07 14:21:30]

tanvir.rizvi@samsung.com changed reviewers:
+ xiaochengh@chromium.org

[tanvir, 2017-06-07 14:21:31]

PTAL!!! This is PS1 as discussed in https://codereview.chromium.org/2916043002/.

Thanks

[Xiaocheng, 2017-06-07 17:29:30]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2017-06-07 17:29:31]

+tkent

lgtm with nits

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right):

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:121: // and is independent
of core functionality of LocalFrame. This should be moved
nit: s/independent of/irrelevant to/

The function does depend on the core functionalities of LocalFrame. The function
is not a core functionality by itself, though.

Same applies to all TODO items below.

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:769:
std::unique_ptr<DragImage> LocalFrame::DragImageForSelection(float opacity) {
nit: Could you also add a TODO to this function?

[tkent, 2017-06-08 01:40:07]

lgtm

[tanvir, 2017-06-08 06:01:59]

updated patch.

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right):

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:121: // and is independent
of core functionality of LocalFrame. This should be moved
On 2017/06/07 17:29:31, Xiaocheng wrote:
> nit: s/independent of/irrelevant to/
> 
> The function does depend on the core functionalities of LocalFrame. The
function
> is not a core functionality by itself, though.
> 
> Same applies to all TODO items below.

Done.

https://codereview.chromium.org/2924013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:769:
std::unique_ptr<DragImage> LocalFrame::DragImageForSelection(float opacity) {
On 2017/06/07 17:29:31, Xiaocheng wrote:
> nit: Could you also add a TODO to this function?

Done.

[tanvir, 2017-06-08 06:02:02]

updated patch.

[tanvir, 2017-06-08 06:02:40]

The CQ bit was checked by tanvir.rizvi@samsung.com

[tanvir, 2017-06-08 06:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2924013002/#ps20001
(title: "updated")

[commit-bot: I haz the power, 2017-06-08 06:03:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 07:39:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496901760103760,
"parent_rev": "a8f9e65ca0db08280344fb615c3a841622fc14ae", "commit_rev":
"857d0cf0147891b495e4df5260bb1e51be5e3980"}

[commit-bot: I haz the power, 2017-06-08 07:39:16]

Description was changed from

==========
Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts

Rename CreateDragImage to CreateDragImageForFrame to avoid name
conflicts and add TODO for movement of drag related functionality
out of LocalFrame class.
These functionalities are independent of core functionality of
LocalFrame so these can be moved out of LocalFrame.

BUG=727981
==========

to

==========
Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts

Rename CreateDragImage to CreateDragImageForFrame to avoid name
conflicts and add TODO for movement of drag related functionality
out of LocalFrame class.
These functionalities are independent of core functionality of
LocalFrame so these can be moved out of LocalFrame.

BUG=727981

Review-Url: https://codereview.chromium.org/2924013002
Cr-Commit-Position: refs/heads/master@{#477919}
Committed:
https://chromium.googlesource.com/chromium/src/+/857d0cf0147891b495e4df5260bb...
==========

[commit-bot: I haz the power, 2017-06-08 07:39:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/857d0cf0147891b495e4df5260bb...