Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2923973002: Reload the Most Visited section when it changes (Closed)

Created:
3 years, 6 months ago by gambard
Modified:
3 years, 6 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reload the Most Visited section when it changes When the Most Visited model changes, the UI should be updated only on user interaction. BUG=707754, 724427, 724499 Review-Url: https://codereview.chromium.org/2923973002 Cr-Commit-Position: refs/heads/master@{#477610} Committed: https://chromium.googlesource.com/chromium/src/+/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 2 5 chunks +23 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
gambard
PTAL.
3 years, 6 months ago (2017-06-07 08:22:27 UTC) #2
lpromero
lgtm https://codereview.chromium.org/2923973002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm (right): https://codereview.chromium.org/2923973002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm#newcode386 ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:386: // prevent updating the all the tiles without ...
3 years, 6 months ago (2017-06-07 08:57:30 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2923973002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm (right): https://codereview.chromium.org/2923973002/diff/20001/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm#newcode386 ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:386: // prevent updating the all the tiles without ...
3 years, 6 months ago (2017-06-07 10:54:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923973002/40001
3 years, 6 months ago (2017-06-07 10:54:29 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 11:05:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/28050dfc93a9ff9de70fcfba4e49...

Powered by Google App Engine
This is Rietveld 408576698