Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2923843002: Use desktop toolbar icons in VR. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Use desktop toolbar icons in VR. Previously, VR was using similar-looking icons to the desktop location bar. This CL switches to use the same icons. As a result, the VR lock icon no longer has a key-hole in it. BUG=728175 Change-Id: I3c7af24303db28d5de5157ed6cf37c362d70cc88 Reviewed-on: https://chromium-review.googlesource.com/521322 Reviewed-by: Evan Stade <estade@chromium.org>; Reviewed-by: Peter Kasting <pkasting@chromium.org>; Commit-Queue: Christopher Grant <cjgrant@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477120} Review-Url: https://codereview.chromium.org/2923843002 . Cr-Commit-Position: refs/branch-heads/3112@{#192} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/49e1d0dfe45f9c748178eac73e41266534c10c90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 3 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/toolbar/BUILD.gn View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-06-06 18:13:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49e1d0dfe45f9c748178eac73e41266534c10c90.

Powered by Google App Engine
This is Rietveld 408576698