Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2923823002: [WebVR] Handle slow connecting devices. (Closed)

Created:
3 years, 6 months ago by amp
Modified:
3 years, 6 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[WebVR] Handle slow connecting devices. A race condition exists when entering WebVR while already in VR (from VrShell) which slows down devices connecting. We keep track if we have seen an immediate handling of the device without a connection (which signifies that libraries aren't loaded) which allows us to return a 0 count in that case, but return non-zero in the case where a device will eventually connect. BUG=729614 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2916423002 Cr-Original-Commit-Position: refs/heads/master@{#477103} Review-Url: https://codereview.chromium.org/2923823002 Cr-Commit-Position: refs/branch-heads/3112@{#186} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/d15601fcab3d91e87952272473056bfc82f8f141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M device/vr/vr_service_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr_service_impl.cc View 4 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
amp
drover merge to 60
3 years, 6 months ago (2017-06-06 16:27:08 UTC) #2
mthiesse
On 2017/06/06 16:27:08, amp wrote: > drover merge to 60 Lgtm
3 years, 6 months ago (2017-06-06 16:37:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923823002/1
3 years, 6 months ago (2017-06-06 16:46:00 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 16:46:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d15601fcab3d91e8795227247305...

Powered by Google App Engine
This is Rietveld 408576698