Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2923803002: Make possible to remove the last most visited tile (Closed)

Created:
3 years, 6 months ago by gambard
Modified:
3 years, 6 months ago
Reviewers:
justincohen
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, fhorschig
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make possible to remove the last most visited tile The last Most Visited tile could not be removed in the NTP. This CL fixes it. BUG=730033 Review-Url: https://codereview.chromium.org/2923803002 Cr-Commit-Position: refs/heads/master@{#477569} Committed: https://chromium.googlesource.com/chromium/src/+/b90a205103775b54fac946c7617222ba9700b544

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ios/chrome/browser/ui/ntp/google_landing_mediator.mm View 1 chunk +0 lines, -4 lines 4 comments Download

Messages

Total messages: 10 (4 generated)
gambard
justincohen@: PTAL fhorschig@: FYI
3 years, 6 months ago (2017-06-06 15:40:52 UTC) #2
justincohen
https://codereview.chromium.org/2923803002/diff/1/ios/chrome/browser/ui/ntp/google_landing_mediator.mm File ios/chrome/browser/ui/ntp/google_landing_mediator.mm (right): https://codereview.chromium.org/2923803002/diff/1/ios/chrome/browser/ui/ntp/google_landing_mediator.mm#newcode251 ios/chrome/browser/ui/ntp/google_landing_mediator.mm:251: if (_mostVisitedData.size() > 0) { When you remove the ...
3 years, 6 months ago (2017-06-06 15:47:34 UTC) #3
gambard
https://codereview.chromium.org/2923803002/diff/1/ios/chrome/browser/ui/ntp/google_landing_mediator.mm File ios/chrome/browser/ui/ntp/google_landing_mediator.mm (right): https://codereview.chromium.org/2923803002/diff/1/ios/chrome/browser/ui/ntp/google_landing_mediator.mm#newcode251 ios/chrome/browser/ui/ntp/google_landing_mediator.mm:251: if (_mostVisitedData.size() > 0) { On 2017/06/06 15:47:34, justincohen ...
3 years, 6 months ago (2017-06-06 16:19:23 UTC) #4
justincohen
LGTM
3 years, 6 months ago (2017-06-06 16:25:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923803002/1
3 years, 6 months ago (2017-06-07 06:50:07 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 07:02:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b90a205103775b54fac946c76172...

Powered by Google App Engine
This is Rietveld 408576698