Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2923773002: Fix include guards in //device/usb (Closed)

Created:
3 years, 6 months ago by Ravi Nanjundappa
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include guards in //device/usb This patch updates the include guards for all .h files in //device/usb BUG=728444 Review-Url: https://codereview.chromium.org/2923773002 Cr-Commit-Position: refs/heads/master@{#477882} Committed: https://chromium.googlesource.com/chromium/src/+/0867b7646e170b2685bb47ed938fb4562f55c0df

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix include guards in //device/usb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/fake_usb_device_handle.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M device/usb/usb_device_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M device/usb/usb_service_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M device/usb/usb_service_linux.h View 2 chunks +5 lines, -0 lines 0 comments Download
M device/usb/usb_service_win.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Ravi Nanjundappa
PTAL
3 years, 6 months ago (2017-06-06 04:58:48 UTC) #1
Ravi Nanjundappa
3 years, 6 months ago (2017-06-06 05:06:12 UTC) #3
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2923773002/diff/1/device/usb/fake_usb_device_handle.h File device/usb/fake_usb_device_handle.h (right): https://codereview.chromium.org/2923773002/diff/1/device/usb/fake_usb_device_handle.h#newcode5 device/usb/fake_usb_device_handle.h:5: #ifndef DEVICE_USB_USB_DEVICE_HANDLE_H_ This include guard should be DEVICE_USB_FAKE_USB_DEVICE_HANDLE_H_, see ...
3 years, 6 months ago (2017-06-06 21:35:50 UTC) #4
Reilly Grant (use Gerrit)
I've removed pfeldman@ from this review. Please only include one OWNER for each file.
3 years, 6 months ago (2017-06-06 21:37:36 UTC) #7
Ravi Nanjundappa
On 2017/06/06 21:37:36, Reilly Grant wrote: > I've removed pfeldman@ from this review. Please only ...
3 years, 6 months ago (2017-06-07 02:57:59 UTC) #8
Ravi Nanjundappa
https://codereview.chromium.org/2923773002/diff/1/device/usb/fake_usb_device_handle.h File device/usb/fake_usb_device_handle.h (right): https://codereview.chromium.org/2923773002/diff/1/device/usb/fake_usb_device_handle.h#newcode5 device/usb/fake_usb_device_handle.h:5: #ifndef DEVICE_USB_USB_DEVICE_HANDLE_H_ On 2017/06/06 21:35:49, Reilly Grant wrote: > ...
3 years, 6 months ago (2017-06-07 03:22:01 UTC) #9
Ravi Nanjundappa
Fixed the review comments. PTAL.
3 years, 6 months ago (2017-06-07 03:24:31 UTC) #10
Reilly Grant (use Gerrit)
lgtm
3 years, 6 months ago (2017-06-07 15:07:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923773002/20001
3 years, 6 months ago (2017-06-08 02:53:28 UTC) #13
commit-bot: I haz the power
The author nravi.n@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 6 months ago (2017-06-08 02:53:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923773002/20001
3 years, 6 months ago (2017-06-08 03:08:39 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 04:12:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0867b7646e170b2685bb47ed938f...

Powered by Google App Engine
This is Rietveld 408576698