Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2923723002: Avoid toggling app list if interrupted by mouse (Closed)

Created:
3 years, 6 months ago by weidongg
Modified:
3 years, 5 months ago
Reviewers:
afakhry, oshima, sadrul
CC:
chromium-reviews, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid toggling app list if interrupted by mouse If mouse press/release occurs between search key down and up, avoid toggling app list. This is helpful when user is chromoting from chromeos to other system which uses 'Win+Click' as a gesture. BUG=665897 TEST= ash_unittests --gtest_filter= 'AcceleratorControllerTest.GlobalAcceleratorsToggleAppList' ash_unittests --gtest_filter= 'AcceleratorFilterTest.ToggleAppListInterruptedByMouseEvent' Review-Url: https://codereview.chromium.org/2923723002 Cr-Commit-Position: refs/heads/master@{#485107} Committed: https://chromium.googlesource.com/chromium/src/+/272d1bb23336c996a82630c0711c19d94a480ad0

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : Add unit test in accelerator_filter_unittest.cc #

Total comments: 2

Patch Set 4 : Rebase and refactor is_interrupted_by_mouse_event() to interrupted_by_mouse_event() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -4 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.h View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M ui/base/accelerators/accelerator_history.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator_history.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/wm/core/accelerator_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
weidongg
oshima@chromium.org, sadrul@chromium.org: Please review changes.
3 years, 6 months ago (2017-06-06 17:17:36 UTC) #7
sadrul
+afakhry@ I seem to remember we discussed removing the use AcceleratorHistory, and replace it with ...
3 years, 6 months ago (2017-06-07 21:53:08 UTC) #9
weidongg
On 2017/06/07 21:53:08, sadrul wrote: > +afakhry@ I seem to remember we discussed removing the ...
3 years, 6 months ago (2017-06-12 21:01:25 UTC) #10
afakhry
On 2017/06/12 21:01:25, weidongg wrote: > On 2017/06/07 21:53:08, sadrul wrote: > > +afakhry@ I ...
3 years, 6 months ago (2017-06-13 16:50:00 UTC) #11
oshima
alternative, we can insert the fake accelerator that indicates that a mouse is pressed. I ...
3 years, 6 months ago (2017-06-16 00:37:30 UTC) #12
weidongg
On 2017/06/16 00:37:30, oshima wrote: > alternative, we can insert the fake accelerator that indicates ...
3 years, 6 months ago (2017-06-22 17:19:21 UTC) #13
sadrul
On 2017/06/22 17:19:21, weidongg wrote: > On 2017/06/16 00:37:30, oshima wrote: > > alternative, we ...
3 years, 5 months ago (2017-06-26 22:17:32 UTC) #14
weidongg
On 2017/06/26 22:17:32, sadrul wrote: > On 2017/06/22 17:19:21, weidongg wrote: > > On 2017/06/16 ...
3 years, 5 months ago (2017-06-27 19:13:13 UTC) #15
sadrul
Thanks! lgtm
3 years, 5 months ago (2017-06-28 04:59:28 UTC) #17
weidongg
Friendly ping, @oshima. Is there any update on this changes?
3 years, 5 months ago (2017-07-07 22:23:11 UTC) #18
oshima
lgtm https://codereview.chromium.org/2923723002/diff/40001/ui/base/accelerators/accelerator.h File ui/base/accelerators/accelerator.h (right): https://codereview.chromium.org/2923723002/diff/40001/ui/base/accelerators/accelerator.h#newcode96 ui/base/accelerators/accelerator.h:96: bool is_interrupted_by_mouse_event() const { nit: interrupted_by_mouse_event() (or you ...
3 years, 5 months ago (2017-07-07 22:28:41 UTC) #19
weidongg
Thanks for the reviews. https://codereview.chromium.org/2923723002/diff/40001/ui/base/accelerators/accelerator.h File ui/base/accelerators/accelerator.h (right): https://codereview.chromium.org/2923723002/diff/40001/ui/base/accelerators/accelerator.h#newcode96 ui/base/accelerators/accelerator.h:96: bool is_interrupted_by_mouse_event() const { On ...
3 years, 5 months ago (2017-07-07 22:55:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923723002/60001
3 years, 5 months ago (2017-07-07 22:56:08 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 00:01:31 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/272d1bb23336c996a82630c0711c...

Powered by Google App Engine
This is Rietveld 408576698