Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2923633002: Move identically named TestTabModel classes to anonymous namespace. (Closed)

Created:
3 years, 6 months ago by Tobias Sargeant
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move identically named TestTabModel classes to anonymous namespace. BUG=727268 Review-Url: https://codereview.chromium.org/2923633002 Cr-Commit-Position: refs/heads/master@{#477593} Committed: https://chromium.googlesource.com/chromium/src/+/edb6019507beff39851bb307abd35c288dc0d5aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/android/tab_model/tab_model_list_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Tobias Sargeant
Hi David. In my hands this change fixes the linked ASAN bot issue. Could you ...
3 years, 6 months ago (2017-06-05 18:15:34 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 6 months ago (2017-06-07 05:54:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923633002/1
3 years, 6 months ago (2017-06-07 08:47:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/111961)
3 years, 6 months ago (2017-06-07 08:51:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923633002/1
3 years, 6 months ago (2017-06-07 09:12:30 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 09:26:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edb6019507beff39851bb307abd3...

Powered by Google App Engine
This is Rietveld 408576698