Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 292363005: Prevent media::ClocklessAudioSink from stopping already stopped threads. (Closed)

Created:
6 years, 7 months ago by scherkus (not reviewing)
Modified:
6 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Prevent media::ClocklessAudioSink from stopping already stopped threads. r272301 uncovered a bug in ClocklessAudioSink where calling Pause() prior to Stop() would attempt to stop the thread twice. BUG=376578 TBR=dalecurtis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M media/audio/clockless_audio_sink.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 7 months ago (2014-05-23 02:38:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/292363005/1
6 years, 7 months ago (2014-05-23 02:39:36 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:07:37 UTC) #3
Message was sent while issue was closed.
Change committed as 272486

Powered by Google App Engine
This is Rietveld 408576698