Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Issue 2923623002: Fix Flaky Mouse latency test. (Closed)

Created:
3 years, 6 months ago by tdresser
Modified:
3 years, 6 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Flaky Mouse latency test. There are some timing issues that are tricky to get right for cases where rendering is scheduled due to mouse input. Fix the flake by preventing rendering from being scheduled. Mouse down was triggering text selection logic, which scheduled rendering. To prevent this, use user-select:none. BUG=728486 Review-Url: https://codereview.chromium.org/2923623002 Cr-Commit-Position: refs/heads/master@{#477037} Committed: https://chromium.googlesource.com/chromium/src/+/ecfb2ded05e975b139ea9929958b3b366c65f93e

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/renderer_host/input/mouse_latency_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tdresser
3 years, 6 months ago (2017-06-05 17:50:57 UTC) #2
dtapuska
On 2017/06/05 17:50:57, tdresser wrote: lgtm
3 years, 6 months ago (2017-06-05 17:58:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923623002/20001
3 years, 6 months ago (2017-06-05 18:09:15 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 18:36:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ecfb2ded05e975b139ea9929958b...

Powered by Google App Engine
This is Rietveld 408576698