Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2923613002: Remove type parameters from type promotion classes. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -70 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart View 23 chunks +59 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-05 17:25:47 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-05 17:31:06 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-05 18:42:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3285dcf039656fc7641bbd984f7acfb8a4cf7346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698