Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2923613002: Remove type parameters from type promotion classes. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index ecb416250fc483fdcc6a842fb2ffb9c80171a58c..c2c08040f35e7dc505ec7a928fe8b11463974c70 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -1705,13 +1705,7 @@ class KernelTypeLiteral extends TypeLiteral implements KernelExpression {
/// Concrete implementation of [TypePromoter] specialized to work with kernel
/// objects.
-///
-/// Note: the second type parameter really ought to be
-/// KernelVariableDeclaration, but we can't do that yet because BodyBuilder
-/// still uses raw VariableDeclaration objects sometimes.
-/// TODO(paulberry): fix this.
-class KernelTypePromoter
- extends TypePromoterImpl<Expression, VariableDeclaration> {
+class KernelTypePromoter extends TypePromoterImpl {
@override
int getVariableFunctionNestingLevel(VariableDeclaration variable) {
if (variable is KernelVariableDeclaration) {
@@ -1841,7 +1835,7 @@ class KernelVariableDeclaration extends VariableDeclaration
/// Concrete shadow object representing a read from a variable in kernel form.
class KernelVariableGet extends VariableGet implements KernelExpression {
- final TypePromotionFact<VariableDeclaration> _fact;
+ final TypePromotionFact _fact;
final TypePromotionScope _scope;
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698