Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2923593002: Explicitly naming the story in the octane benchmark (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly naming the story in the octane benchmark BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2923593002 Cr-Commit-Position: refs/heads/master@{#477070} Committed: https://chromium.googlesource.com/chromium/src/+/ca6fd7a1d017ac0914ef2e1651c3557812ff52ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/benchmarks/octane.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 16:48:19 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-05 16:54:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923593002/1
3 years, 6 months ago (2017-06-05 18:29:08 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 20:24:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca6fd7a1d017ac0914ef2e1651c3...

Powered by Google App Engine
This is Rietveld 408576698