Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2923563005: [ObjC ARC] Converts ios/web/public/test/http_server:http_server to ARC. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
Reviewers:
huangml1, liaoyuke
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web/public/test/http_server:http_server to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2923563005 Cr-Commit-Position: refs/heads/master@{#478161} Committed: https://chromium.googlesource.com/chromium/src/+/4e658ccd98032a0bafc7128a86b423a4436e7407

Patch Set 1 #

Patch Set 2 : cleanup #

Messages

Total messages: 18 (9 generated)
baxley
3 years, 6 months ago (2017-06-06 17:34:39 UTC) #4
baxley
3 years, 6 months ago (2017-06-07 15:29:34 UTC) #6
huangml1
lgtm
3 years, 6 months ago (2017-06-07 17:28:24 UTC) #7
baxley
liaoyuke@, ping!
3 years, 6 months ago (2017-06-08 20:48:22 UTC) #8
liaoyuke
On 2017/06/08 20:48:22, baxley wrote: > liaoyuke@, ping! lgtm!
3 years, 6 months ago (2017-06-08 20:51:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923563005/20001
3 years, 6 months ago (2017-06-08 20:52:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/464342)
3 years, 6 months ago (2017-06-08 22:31:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923563005/20001
3 years, 6 months ago (2017-06-08 22:32:56 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 02:08:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e658ccd98032a0bafc7128a86b4...

Powered by Google App Engine
This is Rietveld 408576698