Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: tools/perf/page_sets/media_cns_cases.py

Issue 2923543002: Explicitly setting names for media story sets (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/mse_cases.py » ('j') | tools/perf/page_sets/tough_video_cases.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/media_cns_cases.py
diff --git a/tools/perf/page_sets/media_cns_cases.py b/tools/perf/page_sets/media_cns_cases.py
index 6af068ae69bc92b753b8d82591ccaed2c902f428..a7710f96fd732f6e6ce3ab84e0aba03163c52630 100644
--- a/tools/perf/page_sets/media_cns_cases.py
+++ b/tools/perf/page_sets/media_cns_cases.py
@@ -46,7 +46,7 @@ class MediaCnsCasesPageSet(story.StorySet):
""" Media benchmark on network constrained conditions. """
def __init__(self):
- super(MediaCnsCasesPageSet, self).__init__()
+ super(MediaCnsCasesPageSet, self).__init__(verify_names=True)
urls_list = [
# pylint: disable=line-too-long
@@ -94,7 +94,7 @@ class MediaCnsCasesPageSet(story.StorySet):
]
for url in urls_list:
- self.AddStory(BasicPlayPage(url, self))
+ self.AddStory(BasicPlayPage(url, self, url.split('/')[-1]))
urls_list2 = [
# pylint: disable=line-too-long
@@ -117,5 +117,6 @@ class MediaCnsCasesPageSet(story.StorySet):
if url in urls_list:
name = 'seek_' + url
else:
- name = ''
+ name = url.split('/')[-1]
+ print name
johnchen 2017/06/05 14:11:52 Is "print name" intended to be permanent, or just
ashleymarie1 2017/06/05 14:16:15 Just for debugging; I saw this and uploaded a seco
self.AddStory(SeekBeforeAndAfterPlayheadPage(url, self, name=name))
« no previous file with comments | « no previous file | tools/perf/page_sets/mse_cases.py » ('j') | tools/perf/page_sets/tough_video_cases.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698