Add TRACE_EVENT markers to various keyboard functions

Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents


BUG=725789
Review-Url: https://codereview.chromium.org/2923493002
Cr-Commit-Position: refs/heads/master@{#478539}
Committed: https://chromium.googlesource.com/chromium/src/+/62a660800ddf7f8d41da872743d5ea5044fd2fb0

[Blake O(Apostrophe)Hare, 2017-06-05 06:52:49]

Description was changed from

==========
Add TRACE_EVENT markers to various keyboard functions



BUG=725789
==========

to

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard


BUG=725789
==========

[Blake O(Apostrophe)Hare, 2017-06-05 06:53:14]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 06:53:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Blake O(Apostrophe)Hare, 2017-06-05 07:36:13]

blakeo@chromium.org changed reviewers:
+ oka@chromium.org, yhanada@chromium.org

[commit-bot: I haz the power, 2017-06-05 07:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 07:40:36]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-06-06 10:42:35]

Could you add TRACE_EVENTs in KeyboardUIContent::ReloadKeyboardIfNeeded(),
KeyboardUI::EnsureCaretInWorkArea(),
VirtualKeyboardController::MoveKeyboardToDisplay() and
VirtualKeyboardController::MoveKeyboardToTouchableDisplay?

These points may be useful to separate CPU time into IME extension part and
window layout part.

https://codereview.chromium.org/2923493002/diff/1/ui/keyboard/keyboard_contro...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/2923493002/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller.cc:249: TRACE_EVENT0("vk", "HideKeyboard");
Can you use longer name for the trace marker group? "virtual_keyboard"?

[oka, 2017-06-06 11:12:05]

lgtm

Sorry for belated. LGTM modulo Hanada-san's comment.

[Blake O(Apostrophe)Hare, 2017-06-09 02:17:13]

Description was changed from

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard


BUG=725789
==========

to

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal


BUG=725789
==========

[Blake O(Apostrophe)Hare, 2017-06-09 02:17:22]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 02:17:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Blake O(Apostrophe)Hare, 2017-06-09 02:18:32]

Description was changed from

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal


BUG=725789
==========

to

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents


BUG=725789
==========

[Blake O(Apostrophe)Hare, 2017-06-09 02:19:17]

More markers

[commit-bot: I haz the power, 2017-06-09 03:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 03:03:57]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-06-09 05:39:49]

lgtm

[Blake O(Apostrophe)Hare, 2017-06-09 06:02:08]

The CQ bit was checked by blakeo@chromium.org

[Blake O(Apostrophe)Hare, 2017-06-09 06:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2923493002/#ps20001
(title: "more trace markers")

[commit-bot: I haz the power, 2017-06-09 06:02:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 06:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 06:10:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Blake O(Apostrophe)Hare, 2017-06-09 08:04:29]

blakeo@chromium.org changed reviewers:
+ oshima@chromium.org

[Blake O(Apostrophe)Hare, 2017-06-09 08:04:45]

+oshima for ash OWNERS

[oshima, 2017-06-09 15:38:01]

lgtm

[Blake O(Apostrophe)Hare, 2017-06-12 01:12:44]

The CQ bit was checked by blakeo@chromium.org

[commit-bot: I haz the power, 2017-06-12 01:12:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 02:03:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497229964744060,
"parent_rev": "84a666fb8915bb9cce45bb5caeb6a30a7f9d9b4c", "commit_rev":
"62a660800ddf7f8d41da872743d5ea5044fd2fb0"}

[commit-bot: I haz the power, 2017-06-12 02:03:56]

Description was changed from

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents


BUG=725789
==========

to

==========
Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents


BUG=725789

Review-Url: https://codereview.chromium.org/2923493002
Cr-Commit-Position: refs/heads/master@{#478539}
Committed:
https://chromium.googlesource.com/chromium/src/+/62a660800ddf7f8d41da872743d5...
==========

[commit-bot: I haz the power, 2017-06-12 02:03:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/62a660800ddf7f8d41da872743d5...