Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2923463002: Don't move raw pointers in content (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
Reviewers:
jsbell, cmumford, dmurph
CC:
chromium-reviews, jam, jsbell+idb_chromium.org, darin-cc_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't move raw pointers in content Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=729393 Review-Url: https://codereview.chromium.org/2923463002 Cr-Commit-Position: refs/heads/master@{#477229} Committed: https://chromium.googlesource.com/chromium/src/+/36da30c60297a992d61bfcc5065e6532adc62cf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
vabr (Chromium)
Hi cmumford@, Could you please review? Thanks, Vaclav
3 years, 6 months ago (2017-06-04 12:28:16 UTC) #6
jsbell
dmurph@ should probably review this one.
3 years, 6 months ago (2017-06-05 16:20:20 UTC) #8
cmumford
lgtm
3 years, 6 months ago (2017-06-05 17:41:20 UTC) #9
dmurph
lgtm
3 years, 6 months ago (2017-06-05 20:26:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923463002/1
3 years, 6 months ago (2017-06-06 06:44:43 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 07:55:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36da30c60297a992d61bfcc5065e...

Powered by Google App Engine
This is Rietveld 408576698