Don't move raw pointers in sync

Don't move raw pointers in sync

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
Review-Url: https://codereview.chromium.org/2923453002
Cr-Commit-Position: refs/heads/master@{#477250}
Committed: https://chromium.googlesource.com/chromium/src/+/75d70fe16e59fdacf28d65749cbc8c6f446a705a

[vabr (Chromium), 2017-06-04 11:02:09]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 11:02:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-06-04 11:06:55]

Description was changed from

==========
Don't move raw pointers in profile_sync_service.cc

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
==========

to

==========
Don't move raw pointers in sync

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
==========

[vabr (Chromium), 2017-06-04 11:07:02]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 11:07:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 12:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 12:12:39]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-06-04 12:26:45]

vabr@chromium.org changed reviewers:
+ pavely@chromium.org

[vabr (Chromium), 2017-06-04 12:26:45]

Hi Pavel,
Could you please review?
Thanks!
Vaclav

[pavely, 2017-06-05 17:44:04]

lgtm

[vabr (Chromium), 2017-06-06 06:44:50]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-06-06 06:45:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 07:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 07:54:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vabr (Chromium), 2017-06-06 09:57:23]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-06-06 09:57:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 10:02:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496743043930020,
"parent_rev": "ef213451f4b167575e075a8ec0e5683d0a6a5ea1", "commit_rev":
"75d70fe16e59fdacf28d65749cbc8c6f446a705a"}

[commit-bot: I haz the power, 2017-06-06 10:02:28]

Description was changed from

==========
Don't move raw pointers in sync

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
==========

to

==========
Don't move raw pointers in sync

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393

Review-Url: https://codereview.chromium.org/2923453002
Cr-Commit-Position: refs/heads/master@{#477250}
Committed:
https://chromium.googlesource.com/chromium/src/+/75d70fe16e59fdacf28d65749cbc...
==========

[commit-bot: I haz the power, 2017-06-06 10:02:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75d70fe16e59fdacf28d65749cbc...