chrome/renderer/searchbox/searchbox_extension.h - Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox_extension.h

Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Tweaked a comment in WebViewPlugin::WebViewHelper::main_frame [as suggested in CR feedback] Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/searchbox/searchbox_extension.h

diff --git a/chrome/renderer/searchbox/searchbox_extension.h b/chrome/renderer/searchbox/searchbox_extension.h

index 3f86ca02b25ceaf51b7b75f2da6a532c2cf398ee..87c38f2142109d3991b6bf1e95726d5bff262025 100644

--- a/chrome/renderer/searchbox/searchbox_extension.h

+++ b/chrome/renderer/searchbox/searchbox_extension.h

@@ -13,7 +13,7 @@ class Extension;

}

namespace blink {

-class WebFrame;

+class WebLocalFrame;

}

namespace extensions_v8 {

@@ -27,19 +27,19 @@ class SearchBoxExtension {

static v8::Extension* Get();

// Helpers to dispatch Javascript events.

- static void DispatchChromeIdentityCheckResult(blink::WebFrame* frame,

+ static void DispatchChromeIdentityCheckResult(blink::WebLocalFrame* frame,

const base::string16& identity,

bool identity_match);

- static void DispatchFocusChange(blink::WebFrame* frame);

- static void DispatchHistorySyncCheckResult(blink::WebFrame* frame,

+ static void DispatchFocusChange(blink::WebLocalFrame* frame);

+ static void DispatchHistorySyncCheckResult(blink::WebLocalFrame* frame,

bool sync_history);

- static void DispatchInputCancel(blink::WebFrame* frame);

- static void DispatchInputStart(blink::WebFrame* frame);

- static void DispatchKeyCaptureChange(blink::WebFrame* frame);

- static void DispatchMostVisitedChanged(blink::WebFrame* frame);

- static void DispatchSubmit(blink::WebFrame* frame);

- static void DispatchSuggestionChange(blink::WebFrame* frame);

- static void DispatchThemeChange(blink::WebFrame* frame);

+ static void DispatchInputCancel(blink::WebLocalFrame* frame);

+ static void DispatchInputStart(blink::WebLocalFrame* frame);

+ static void DispatchKeyCaptureChange(blink::WebLocalFrame* frame);

+ static void DispatchMostVisitedChanged(blink::WebLocalFrame* frame);

+ static void DispatchSubmit(blink::WebLocalFrame* frame);

+ static void DispatchSuggestionChange(blink::WebLocalFrame* frame);

+ static void DispatchThemeChange(blink::WebLocalFrame* frame);

private:

DISALLOW_IMPLICIT_CONSTRUCTORS(SearchBoxExtension);