chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Tweaked a comment in WebViewPlugin::WebViewHelper::main_frame [as suggested in CR feedback] Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index 52c772c246e876659710f64bd3afc5f78d65170b..c3009742c9e143bd20497604a15b782234a39c1e 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -212,7 +212,7 @@ class PhishingDOMFeatureExtractorTest : public ChromeRenderViewTest {

// Does the actual work of removing the iframe "frame1" from the document.

void RemoveIframe() {

- blink::WebFrame* main_frame = GetMainFrame();

+ blink::WebLocalFrame* main_frame = GetMainFrame();

ASSERT_TRUE(main_frame);

main_frame->ExecuteScript(blink::WebString(

"document.body.removeChild(document.getElementById('frame1'));"));

« no previous file with comments | « no previous file | chrome/renderer/searchbox/searchbox_extension.h » ('j') | no next file with comments »