Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2923413003: Split ServiceWorkerURLLoaderJob from URLJobWrapper (Closed)

Created:
3 years, 6 months ago by kinuko
Modified:
3 years, 6 months ago
Reviewers:
falken, scottmg
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split ServiceWorkerURLLoaderJob from URLJobWrapper Also do minor cleanups (not changing things a lot yet). BUG=715640 Review-Url: https://codereview.chromium.org/2923413003 Cr-Commit-Position: refs/heads/master@{#477931} Committed: https://chromium.googlesource.com/chromium/src/+/d9008b2d47367a5a627d6c8c5db33be5aac10142

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -266 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_job_wrapper.h View 3 chunks +6 lines, -49 lines 0 comments Download
M content/browser/service_worker/service_worker_url_job_wrapper.cc View 1 2 chunks +21 lines, -215 lines 0 comments Download
A content/browser/service_worker/service_worker_url_loader_job.h View 1 1 chunk +114 lines, -0 lines 0 comments Download
A content/browser/service_worker/service_worker_url_loader_job.cc View 1 1 chunk +222 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
kinuko
Refactoring only, not changing things a lot. PTL
3 years, 6 months ago (2017-06-07 15:37:07 UTC) #7
scottmg
lgtm
3 years, 6 months ago (2017-06-07 18:54:08 UTC) #10
kinuko
Matt - I'm landing this, I'll land more cleanups / follow-up fixes later if you ...
3 years, 6 months ago (2017-06-08 09:21:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923413003/20001
3 years, 6 months ago (2017-06-08 09:21:50 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d9008b2d47367a5a627d6c8c5db33be5aac10142
3 years, 6 months ago (2017-06-08 09:26:34 UTC) #20
falken
3 years, 6 months ago (2017-06-09 01:52:38 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698