Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2923363005: Print Preview: Remove unused event (Closed)

Created:
3 years, 6 months ago by rbpotter
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Remove unused event LOCAL_DESTINATIONS_SET is no longer used. Remove the event and modify comment that references it. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2923363005 Cr-Commit-Position: refs/heads/master@{#477840} Committed: https://chromium.googlesource.com/chromium/src/+/269a344191b53f18ec5bfffbdd1ca6be2b3abc61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/native_layer.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
rbpotter
3 years, 6 months ago (2017-06-07 21:30:58 UTC) #6
dpapad
LGTM. I would still link this CL to BUG=717296 since the cleanup is part of ...
3 years, 6 months ago (2017-06-07 21:36:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923363005/1
3 years, 6 months ago (2017-06-08 00:54:22 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:59:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/269a344191b53f18ec5bfffbdd1c...

Powered by Google App Engine
This is Rietveld 408576698