Linux Aura: Use Separate profile key specifically for theme usage

Linux Aura: Use Separate profile key specifically for theme usage

This CL is a revert to patch set 1 of CL [1].  This is necessary
because window position save/restore for the task manager relies on
the regular profile key being null for the task manager widget.

[1] https://codereview.chromium.org/2862113002/#ps1

BUG=729405
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2923323002
Cr-Commit-Position: refs/heads/master@{#477872}
Committed: https://chromium.googlesource.com/chromium/src/+/2e3beeadb7a48af2c3dd58e0ec22085fc988636b

[Tom Anderson, 2017-06-06 23:49:44]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 23:50:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-06 23:51:35]

sky ptal.

I'll also add a browser test to prevent this from regressing yet again..

[commit-bot: I haz the power, 2017-06-06 23:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 23:54:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Anderson, 2017-06-06 23:58:12]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 23:58:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 01:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 01:29:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Anderson, 2017-06-07 03:58:27]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[Tom Anderson, 2017-06-07 03:58:35]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-07 03:58:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-07 03:58:41]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-07 05:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 05:40:18]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-07 16:24:50]

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/native_widget_factory.cc (right):

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/native_widget_factory.cc:31: window =
desktop_native_widget->GetNativeWindow();
How come you aren't setting the kProfileKey here?

[Tom Anderson, 2017-06-07 18:25:23]

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/native_widget_factory.cc (right):

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/native_widget_factory.cc:31: window =
desktop_native_widget->GetNativeWindow();
On 2017/06/07 16:24:50, sky wrote:
> How come you aren't setting the kProfileKey here?

Because doing that would set it for the task manager.  This is how it was
before: only the non-desktop case had the copy. (Don't know what the non-desktop
case needs it for though)

[sky, 2017-06-07 19:47:42]

LGTM

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/native_widget_factory.cc (right):

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/native_widget_factory.cc:31: window =
desktop_native_widget->GetNativeWindow();
On 2017/06/07 18:25:22, Tom Anderson wrote:
> On 2017/06/07 16:24:50, sky wrote:
> > How come you aren't setting the kProfileKey here?
> 
> Because doing that would set it for the task manager.  This is how it was
> before: only the non-desktop case had the copy. (Don't know what the
non-desktop
> case needs it for though)

Ok. Please add a comment here then.

[Tom Anderson, 2017-06-08 00:13:26]

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/native_widget_factory.cc (right):

https://codereview.chromium.org/2923323002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/native_widget_factory.cc:31: window =
desktop_native_widget->GetNativeWindow();
On 2017/06/07 19:47:41, sky wrote:
> On 2017/06/07 18:25:22, Tom Anderson wrote:
> > On 2017/06/07 16:24:50, sky wrote:
> > > How come you aren't setting the kProfileKey here?
> > 
> > Because doing that would set it for the task manager.  This is how it was
> > before: only the non-desktop case had the copy. (Don't know what the
> non-desktop
> > case needs it for though)
> 
> Ok. Please add a comment here then.

Done.

[Tom Anderson, 2017-06-08 00:13:52]

The CQ bit was checked by thomasanderson@chromium.org

[Tom Anderson, 2017-06-08 00:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2923323002/#ps60001
(title: "Add comment")

[commit-bot: I haz the power, 2017-06-08 00:14:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 03:26:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496880832498150,
"parent_rev": "712c1b8ba3219ffe2408837d7b2f2f1253a55f26", "commit_rev":
"2e3beeadb7a48af2c3dd58e0ec22085fc988636b"}

[commit-bot: I haz the power, 2017-06-08 03:26:27]

Description was changed from

==========
Linux Aura: Use Separate profile key specifically for theme usage

This CL is a revert to patch set 1 of CL [1].  This is necessary
because window position save/restore for the task manager relies on
the regular profile key being null for the task manager widget.

[1] https://codereview.chromium.org/2862113002/#ps1

BUG=729405
R=sky@chromium.org
==========

to

==========
Linux Aura: Use Separate profile key specifically for theme usage

This CL is a revert to patch set 1 of CL [1].  This is necessary
because window position save/restore for the task manager relies on
the regular profile key being null for the task manager widget.

[1] https://codereview.chromium.org/2862113002/#ps1

BUG=729405
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2923323002
Cr-Commit-Position: refs/heads/master@{#477872}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e3beeadb7a48af2c3dd58e0ec22...
==========

[commit-bot: I haz the power, 2017-06-08 03:26:29]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2e3beeadb7a48af2c3dd58e0ec22...