Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2923223002: Replace ENABLE_NON_THREAD_SAFE with DCHECK_IS_ON() in image_skia_unittest.cc (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, rsesek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ENABLE_NON_THREAD_SAFE with DCHECK_IS_ON() in image_skia_unittest.cc NonThreadSafe is gone and DCHECK_IS_ON() is the right construct to express such requirements now. BUG=676387 Review-Url: https://codereview.chromium.org/2923223002 Cr-Commit-Position: refs/heads/master@{#477303} Committed: https://chromium.googlesource.com/chromium/src/+/4a6e9d93719ad9f51c1f6f89e1e080d3131e07e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M ui/gfx/image/image_skia_unittest.cc View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gab
oshima@ PTaL and CQ, thanks
3 years, 6 months ago (2017-06-06 14:05:06 UTC) #4
oshima
On 2017/06/06 14:05:06, gab wrote: > oshima@ PTaL and CQ, thanks lgtm
3 years, 6 months ago (2017-06-06 15:51:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923223002/1
3 years, 6 months ago (2017-06-06 15:58:47 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 16:03:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a6e9d93719ad9f51c1f6f89e1e0...

Powered by Google App Engine
This is Rietveld 408576698