Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2923203002: Reland: Update FlatBuffers to include multiple improvements. (Closed)

Created:
3 years, 6 months ago by pkalinnikov
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Update FlatBuffers to include multiple improvements. This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to include the following changes to the library: - d7ac378: Offset<T>::IsNull method. - 93c0960: --keep-prefix compiler option. - c559eb4: Generate files for empty schemas. - aaf5598: Fix path comparison on Windows. - fb87c0d: Improve allocator handling (fixes test). - 22743ca: Fix --keep-prefix bugs. - 642254b: Fix one more --keep-prefix issue. - dd05f32: Add tests for nested FlatBuffers. - 01c50d5: Get rid of move semantics in VectorIterator. This is a reland of https://codereview.chromium.org/2883063002/ with a compile flag added to Windows build suppressing the alignment warning. BUG=611351, 713774 TBR=palmer@chromium.org Review-Url: https://codereview.chromium.org/2923203002 Cr-Commit-Position: refs/heads/master@{#477947} Committed: https://chromium.googlesource.com/chromium/src/+/488ae5249bcea6c46af5e832f8be87dcc8df56e1

Patch Set 1 #

Patch Set 2 : Suppress alignment warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -20 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/flatbuffers/BUILD.gn View 1 4 chunks +30 lines, -12 lines 0 comments Download
M third_party/flatbuffers/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/flatbuffers/flatbuffer.gni View 3 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
pkalinnikov
PTAL, this should fix the build problem on Win bots. This CL only adds a ...
3 years, 6 months ago (2017-06-07 20:38:45 UTC) #14
pkalinnikov
Charlie, PTAL instead of Balazs (OOO).
3 years, 6 months ago (2017-06-08 08:53:07 UTC) #20
Charlie Harrison
On 2017/06/08 08:53:07, pkalinnikov wrote: > Charlie, PTAL instead of Balazs (OOO). Lgtm.
3 years, 6 months ago (2017-06-08 12:04:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923203002/100001
3 years, 6 months ago (2017-06-08 12:05:34 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 12:10:01 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/488ae5249bcea6c46af5e832f8be...

Powered by Google App Engine
This is Rietveld 408576698