Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 6 months ago by jgruber Modified:
3 years, 6 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[string] Re-enable result caching for String.p.split
Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.
BUG=v8:6463
Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{#45724}
Committed: https://chromium.googlesource.com/v8/v8/+/866ee63c581393185de63319aae94b21fc4069dd
Patch Set 1 #Patch Set 2 : Tweak #
Created: 3 years, 6 months ago
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + bmeurer@chromium.org
PTAL. No reason to restrict to Smis here, and defaulting to Smi::kMaxValue (instead of kMaxUInt32) broke result caching.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496748388879720,
"parent_rev": "c22ca7f73ba92f22d0cd29b06bb2944a545a8d3e", "commit_rev":
"866ee63c581393185de63319aae94b21fc4069dd"}
Message was sent while issue was closed.
Description was changed from ========== [string] Re-enable result caching for String.p.split Runtime::kStringSplit's result caching is only enabled when limit equals kMaxUInt32. BUG=v8:6463 ========== to ========== [string] Re-enable result caching for String.p.split Runtime::kStringSplit's result caching is only enabled when limit equals kMaxUInt32. BUG=v8:6463 Review-Url: https://codereview.chromium.org/2923183002 Cr-Commit-Position: refs/heads/master@{#45724} Committed: https://chromium.googlesource.com/v8/v8/+/866ee63c581393185de63319aae94b21fc4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/866ee63c581393185de63319aae94b21fc4... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
