Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2923183002: [string] Re-enable result caching for String.p.split (Closed)

Created:
3 years, 6 months ago by jgruber
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Re-enable result caching for String.p.split Runtime::kStringSplit's result caching is only enabled when limit equals kMaxUInt32. BUG=v8:6463 Review-Url: https://codereview.chromium.org/2923183002 Cr-Commit-Position: refs/heads/master@{#45724} Committed: https://chromium.googlesource.com/v8/v8/+/866ee63c581393185de63319aae94b21fc4069dd

Patch Set 1 #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/builtins/builtins-string-gen.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jgruber
PTAL. No reason to restrict to Smis here, and defaulting to Smi::kMaxValue (instead of kMaxUInt32) ...
3 years, 6 months ago (2017-06-06 10:49:34 UTC) #8
Benedikt Meurer
LGTM
3 years, 6 months ago (2017-06-06 11:16:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923183002/20001
3 years, 6 months ago (2017-06-06 11:27:19 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 11:28:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/866ee63c581393185de63319aae94b21fc4...

Powered by Google App Engine
This is Rietveld 408576698