Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2923163003: Web MIDI: use midi::TaskService in MidiManagerAlsa (Closed)

Created:
3 years, 6 months ago by Takashi Toyoshima
Modified:
3 years, 6 months ago
Reviewers:
Adam Goode, yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, pmalani_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: use midi::TaskService in MidiManagerAlsa This patch replaces existing MidiManagerAlsa implementation to support asynchronous method posts with midi::TaskService that should be used on all platforms now to support such functionalities. BUG=672793 Review-Url: https://codereview.chromium.org/2923163003 Cr-Commit-Position: refs/heads/master@{#479374} Committed: https://chromium.googlesource.com/chromium/src/+/c73f9dc095133071e0d3dd918a9135443aeb8032

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -125 lines) Patch
M media/midi/midi_manager_alsa.h View 4 chunks +2 lines, -19 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 3 4 10 chunks +32 lines, -106 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Takashi Toyoshima
ptal https://codereview.chromium.org/2923163003/diff/1/media/midi/midi_manager_alsa.cc File media/midi/midi_manager_alsa.cc (left): https://codereview.chromium.org/2923163003/diff/1/media/midi/midi_manager_alsa.cc#oldcode183 media/midi/midi_manager_alsa.cc:183: // Take lock to ensure that the members ...
3 years, 6 months ago (2017-06-06 12:06:44 UTC) #5
Adam Goode
lgtm This is a nice cleanup to this code.
3 years, 6 months ago (2017-06-06 14:44:26 UTC) #8
yhirano
lgtm
3 years, 6 months ago (2017-06-14 11:58:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923163003/80001
3 years, 6 months ago (2017-06-14 12:16:32 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 14:14:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c73f9dc095133071e0d3dd918a91...

Powered by Google App Engine
This is Rietveld 408576698