Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2923153002: Move "paragraph" granularity related functions to VisibleUnitParagraph.cpp (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move "paragraph" granularity related functions to VisibleUnitParagraph.cpp This patch moves "paragraph" granularity related functions to "VisibleUnitParagraph.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2923153002 Cr-Commit-Position: refs/heads/master@{#477498} Committed: https://chromium.googlesource.com/chromium/src/+/d458772d4250347ab3ed34e8cf682b16658d208a

Patch Set 1 : 2017-06-06T15:30:01 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -357 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -357 lines 0 comments Download
A third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp View 1 chunk +408 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-06 07:05:22 UTC) #5
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-06 19:54:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923153002/1
3 years, 6 months ago (2017-06-07 00:56:12 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 01:01:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d458772d4250347ab3ed34e8cf68...

Powered by Google App Engine
This is Rietveld 408576698