Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 292313014: Convert pdfium to use LF instead of CRLF for EOL (Closed)

Created:
6 years, 7 months ago by jln (very slow on Chromium)
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Convert pdfium to use LF instead of CRLF for EOL Normalize the whole repository to use "LF" instead of "CRLF" for line endings. Add a .gitattributes with "* text=auto" so that new lines are automatically converted to the native platform's format on checkout but are committed as "LF". BUG=375516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7112 lines, -7111 lines) Patch
A .gitattributes View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1205 lines, -1205 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1488 lines, -1488 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +1774 lines, -1774 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 1 chunk +785 lines, -785 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +879 lines, -879 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +364 lines, -364 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +145 lines, -145 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +470 lines, -470 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
This does two things: 1. Convert the repository to consistently use LF instead of CRLF ...
6 years, 7 months ago (2014-05-23 23:28:46 UTC) #1
jam
lgtm, thanks!
6 years, 7 months ago (2014-05-24 00:19:47 UTC) #2
jam
btw so i ran find . -type f -exec dos2unix {} \; and I found ...
6 years, 7 months ago (2014-05-24 00:33:14 UTC) #3
jam
Landed in https://pdfium.googlesource.com/pdfium/+/5b51e49beb646a378f5cbaf012ff63c982345e66
6 years, 7 months ago (2014-05-24 00:48:40 UTC) #4
jln (very slow on Chromium)
6 years, 7 months ago (2014-05-27 20:35:41 UTC) #5
Message was sent while issue was closed.
On 2014/05/24 00:33:14, jam wrote:
> btw so i ran 
> 
> find . -type f -exec dos2unix {} \;
> 
> and I found that most files had Windows line endings. i'm not sure why it
shows
> that for me but not for you. how did you check?

Yeah, I suspect the review tool skipped them for when I uploaded. I'm not sure
why this would have happened.

Powered by Google App Engine
This is Rietveld 408576698